Skip to content

Fix Java automatic module name#5

Merged
bbottema merged 1 commit into
simple-java-mail:masterfrom
haumacher:fix-automatic-module-name
Jul 4, 2026
Merged

Fix Java automatic module name#5
bbottema merged 1 commit into
simple-java-mail:masterfrom
haumacher:fix-automatic-module-name

Conversation

@haumacher

Copy link
Copy Markdown
Contributor

A Java module name must match the syntax rules for a Java package. Therefore, no "-" signs are allowed there. In the current state, this very nice library unfortunately is not usable from a Java 17 modularized project.

A Java module name must match the syntax rules for a Java package. Therefore, no "-" signs are allowed there.
@haumacher

Copy link
Copy Markdown
Contributor Author

Hi there, any comments/suggestions/complaints?

@SchulteDev

SchulteDev commented Sep 26, 2025

Copy link
Copy Markdown

For anyone being interested in using the fork https://github.com/haumacher/java-utils-mail-dkim/tree/fix-automatic-module-name of @haumacher, you can use it using JitPack.

Maven example:

<dependencies>
  <dependency>
    <groupId>com.github.haumacher</groupId>
    <artifactId>java-utils-mail-dkim</artifactId>
    <version>fix-automatic-module-name-SNAPSHOT</version>
  </dependency>
</dependencies>

<repositories>
  <repository>
    <id>jitpack.io</id>
    <url>https://jitpack.io</url>
  </repository>
</repositories>

@bbottema bbottema merged commit ae0a40f into simple-java-mail:master Jul 4, 2026
@bbottema

bbottema commented Jul 4, 2026

Copy link
Copy Markdown
Member

Merged for attribution in ae0a40f.

The final fix uses org.simplejavamail.utils.mail.dkim as the automatic module name rather than the underscore variant from this branch, but this PR correctly identified the root problem: the old hyphenated Automatic-Module-Name was not a valid Java module name. Thanks @haumacher for the report and patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants